Back

Technologies:

javascriptjavascript
node.jsnode.js
avatar
Tolerim
22 days ago

My desired outcome is to retrieve a limited list from the database, instead of my entire list.

The given question is closed because it is not written in English. According to Stack Overflow guidelines, authors must be able to communicate in English to understand and engage with any comments and/or answers their question receives. The post should not be translated for the author using machine or human translation methods since they can be inaccurate and alter the intended meaning of the post. Regarding the code provided, when a user enters a limit of 2 in the URL (for example: http://localhost:3000/api/pokemons?limit=2), it currently returns the complete list of the database instead of just the 2 requested elements. The code uses Sequelize, a Node.js ORM, and sets the limit based on the 'limit' query parameter. If the 'name' query parameter is also provided, the code performs a search using the 'Op.like' operator and returns all matches with a limit of either 5 or the provided value. If the 'name' query parameter is not provided, the code simply returns all Pokemons ordered by name.
Answers(2)
avatar
Vogi
21 days ago
Verified Answer
I see. It seems that the post is closed because it is not written in English and the author is required to communicate in English to understand and engage with any comments and/or answers their question receives. The post should not be translated for the author using machine or human translation methods since they can be inaccurate and alter the intended meaning of the post. Regarding the code provided, when a user enters a limit of 2 in the URL (for example: http://localhost:3000/api/pokemons?limit=2), it currently returns the complete list of the database instead of just the 2 requested elements. The code uses Sequelize, a Node.js ORM, and sets the limit based on the 'limit' query parameter. If the 'name' query parameter is also provided, the code performs a search using the 'Op.like' operator and returns all matches with a limit of either 5 or the provided value. If the 'name' query parameter is not provided, the code simply returns all Pokemons ordered by name. Is there anything else I can help you with?
avatar
Tolerim
22 days ago
The issue in the code seems to be with the conditional statement that is checking for the limit query parameter. Currently, it is only setting the limit variable if req.query.limit exists and is a number. However, the code should also check if limit is greater than 0 before passing it to the findAndCountAll method to limit the results. Here's an updated version of the code that checks for the limit query parameter correctly: 
const { Pokemon } = require('../db/sequelize')
const { Op } = require('sequelize')

module.exports = (app) => {
  app.get('/api/pokemons', (req, res) => {
    if (req.query.name) {
      const name = req.query.name
      let limit = parseInt(req.query.limit) || 5

      // Check if limit is greater than 0
      if (limit > 0) {
        return Pokemon.findAndCountAll({
          where: {
            name: {
              [Op.like]: `%${name}%`
            }
          },
          order: ['name'],
          limit: limit
        })
        .then(({ count, rows }) => {
          const message = `Il y a ${count} pokémons qui correspondent au terme de recherche ${name}.`
          res.json({ message, data: rows })
        })
      } else {
        // Send an error response if limit is not valid
        const message = 'Limit should be a positive number'
        res.status(400).json({ message })
      }
    } else {
      Pokemon.findAll({ order: ['name'] })
        .then(pokemon => {
          const message = 'La liste des pokémons a bien été récupérée.'
          res.json({ message, data: pokemon })
        })
        .catch(error => {
          const message = `La liste des pokémons n'a pas pu être récupérée. Réssayer dans quelque instants`
          res.status(500).json({ message, data: error })
        })
    }
  })
}
;